added support for "Twig\Markup" instances in the "in" test (again)

twigphp · Jun 3, 2019 · 2218cfe · 2218cfe
1 parent 51f33f7
commit 2218cfe
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 * 1.42.1 (2019-XX-XX)
 
+ * added support for "Twig\Markup" instances in the "in" test (again)
  * allowed string operators as variables names in assignments
 
 * 1.42.0 (2019-05-31)

diff --git a/src/Extension/CoreExtension.php b/src/Extension/CoreExtension.php
@@ -943,6 +943,9 @@ function twig_in_filter($value, $compare)
     if ($value instanceof Markup) {
         $value = (string) $value;
     }
+    if ($compare instanceof Markup) {
+        $compare = (string) $compare;
+    }
 
     if (\is_array($compare)) {
         return \in_array($value, $compare, \is_object($value) || \is_resource($value));

diff --git a/test/Twig/Tests/Fixtures/tests/in.test b/test/Twig/Tests/Fixtures/tests/in.test
@@ -56,6 +56,7 @@ Twig supports the in operator
 {{ '5.5' in 125.5 ? 'KO' : 'OK' }}
 
 {{ safe in ['foo', 'bar'] ? 'OK' : 'KO' }}
+{{ 'fo' in safe ? 'OK' : 'KO' }}
 --DATA--
 return ['bar' => 'bar', 'foo' => ['bar' => 'bar'], 'dir_object' => new \SplFileInfo(dirname(__FILE__)), 'object' => new \stdClass(), 'resource' => opendir(dirname(__FILE__)), 'safe' => new \Twig\Markup('foo', 'UTF-8')]
 --EXPECT--
@@ -114,3 +115,4 @@ OK
 OK
 
 OK
+OK