New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError
by accessing meta
field when return_type
is dict
#1861
Conversation
@Harmon758 Hi, Harmon. Could you please take a look to this PR. Our packages have some functions rely on My regards. |
This comment was marked as resolved.
This comment was marked as resolved.
AttributeError
by accessing meta
field when return_type is dictAttributeError
by accessing meta
field when return_type
is dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With AsyncPaginator
implemented now, a similar fix needs to be applied to it.
I can add it later if it's not part of this PR.
Here is a marker, previous update messages just show rebased records from the latest master branch. |
You've rebased and duplicated 66 commits from the master branch onto your branch. |
@Harmon758 You can review it now, I have added similar patch to
Yeah, I choose the later one that I actually only do rebase my commits onto the latest master. But it seems my commits are too elder to on top of history. I could rewrite these commits with forced push if you cannot rebase into master safely. Regards. |
Squash rebase is an excellent approach to merge |
Again, you've rebased commits from the master branch to your branch, not the other way around. |
@Harmon758 I have fixed that. Sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsyncPaginator
is meant to be used with AsyncClient
, not Client
.
AsyncClient
uses aiohttp
instead of requests
and does not ever return requests.Response
.
…ing from `black`
Sorry, my faults, I forgot to check async http client. |
Really thank you for your patience. 👍 |
I meet totally the same error to #1843
My solution is to add an
isinstance
condition, it's very simple but useful. Any improvement or suggest for this PR is welcome.Regards.