Remove rules_sass and send build metadata to Buildbuddy #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rules were formerly used by skydoc.
Inside a pure nix shell, the `GITHUB_*` environment variables are not set and Buildbuddy cannot determine metadata automatically. See https://www.buildbuddy.io/docs/guide-metadata/
This enables taking advantage of Buildbuddy's cache.
For PRs from forks (and also dependabot) access to the repository secrets is not
permitted, so the API key for Buildbuddy ends up as empty.
This would lead to an error:
```
WARNING: BES was not properly closed
ERROR: The Build Event Protocol upload failed: Not retrying publishBuildEvents, no more attempts left: status='Status{code=UNAUTHENTICATED, description=failed to parse AP
```
avdv
force-pushed
the
maintenance-cleanup
branch
2 times, most recently
from
a8beded
to
3283f34
Compare
avdv
force-pushed
the
maintenance-cleanup
branch
from
3283f34
to
bfdf529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.