Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: drop unused .bi-exclamation-triangle-fill class #39815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 20, 2024

Description

While checking the several docs ongoing PRs, I stumbled upon this .bi-exclamation-triangle-fill class that is useless.
Feel free to close the PR if it's already handled in another PR.

Note: I've checked the presence of other .bi-* classes and it was the only one

@XhmikosR
Copy link
Member

I think we should actually keep the classes and IDs in the icons so that we are close to the upstream code for easier copy-paste. We just need to be consistent from now on and update the sprite and everything from icons to be as close as the upstream code.

@mdo
Copy link
Member

mdo commented Apr 15, 2024

I leave this to the two of you :). Doesn't matter to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants