Fix the color on toast, form-label, modal and card when set the data-bs-theme="dark" on the element itself #38212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jonnysp
changed the title
jonnysp
changed the title
jonnysp
changed the title
jonnysp
changed the title
|
This breaks light mode card variants:
I also don't see a problem in the before state for stuff like form labels and toasts. Do you have screenshots of intended before/after to better show what needs addressing and reviewing here? |
|
ok i fixed the card variants for Carddata-bs-theme="dark" on card itself before after |
for Toastsdata-bs-theme="dark" on toast itself before after |
dropdown exampledark dropdown without any other change to the light dropdown only the data-bs-theme="dark" on itself this fixes the dark preview https://deploy-preview-38212--twbs-bootstrap.netlify.app/docs/5.3/examples/dropdowns/ before after |
for Popoverdata-bs-theme="dark" on Popover itself before after |
jonnysp
changed the title
for Labels and Floating labelsdata-bs-theme="dark" on parent (form) or element itself before after |
|
on accordion, alert, modal, pagination, listgroup, progress the data-bs-theme="dark" already works |
Fix the color when set the data-bs-theme="dark" on the element itself
make the dark variants same as the light variants, to see the theme effects.
table theme dark
jonnysp
force-pushed
the
theme-dark-on-card-and-modal-fix
branch
from
32692e9
to
61471d0
Compare
This reverts commit 61471d0.
jonnysp
changed the title
|
Removed the tables change is fixed by #37084. |
|
fix for example pages in a new pull request #38512 |
jonnysp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the color on table, toast, form-label, modal and card when set the data-bs-theme="dark" on the element itself
and fix the theme switcher in some examples
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues