Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table inconsistent border if caption exists #35197

Closed
wants to merge 4 commits into from
Closed

Fix table inconsistent border if caption exists #35197

wants to merge 4 commits into from

Conversation

dgrammatiko
Copy link

@dgrammatiko dgrammatiko commented Oct 14, 2021

Changes

The selector :not(:first-child) is changed to tbody:first-of-type so that the border-top has consistent results if there is or not a caption element

The problem is reproducible if the table has a caption element but the caption is visually hidden

For reference: joomla/joomla-cms#35766 (comment)

@ffoodd
Copy link
Member

ffoodd commented Oct 14, 2021

That's not appropriate since we want this border for each tbody, precisely. FYI there's an open issue related to this specific CSS when using colgroup element, too: #35152.

I try another way around.

@dgrammatiko
Copy link
Author

That's not appropriate since we want this border for each tbody, precisely.

Ok, I think I can reduce the changes hereto affect only the caption element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants