Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal: don't add margin & padding when sticky is not full width #35164

Closed
wants to merge 1 commit into from

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Oct 11, 2021

modal: don't add margin & padding when sticky is not full width (Backports #30621)
fix #27071

@GeoSot GeoSot added this to Inbox in v4.6.1 via automation Oct 11, 2021
@GeoSot GeoSot added the v4 label Oct 11, 2021
mdo
mdo previously approved these changes Oct 19, 2021
@GeoSot GeoSot force-pushed the gs/v4/modal-with-sticky branch 2 times, most recently from 7f7b6e7 to fc78d52 Compare October 22, 2021 09:37
@GeoSot GeoSot marked this pull request as ready for review October 22, 2021 10:08
@GeoSot GeoSot requested a review from a team as a code owner October 22, 2021 10:08
@XhmikosR XhmikosR marked this pull request as draft October 22, 2021 13:53
@XhmikosR XhmikosR marked this pull request as ready for review October 22, 2021 14:09
@XhmikosR XhmikosR changed the title modal: don't add margin & padding when sticky is not full width (Back… modal: don't add margin & padding when sticky is not full width Oct 22, 2021
@XhmikosR XhmikosR force-pushed the gs/v4/modal-with-sticky branch 2 times, most recently from 1280452 to 28144d8 Compare October 22, 2021 14:21
@XhmikosR
Copy link
Member

@rohit2sharma95 @alpadev LGTY?

@XhmikosR XhmikosR removed this from Inbox in v4.6.1 Oct 26, 2021
@XhmikosR XhmikosR added this to In progress in v4.6.2 via automation Oct 26, 2021
modal: don't add margin & padding when sticky is not full width
@XhmikosR XhmikosR marked this pull request as draft October 26, 2021 13:37
@XhmikosR XhmikosR marked this pull request as ready for review November 15, 2021 10:52
@XhmikosR XhmikosR marked this pull request as draft November 15, 2021 10:53
@GeoSot GeoSot closed this Jan 11, 2022
@XhmikosR XhmikosR removed this from In progress in v4.6.2 Feb 2, 2022
@GeoSot GeoSot deleted the gs/v4/modal-with-sticky branch February 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants