Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border-radius sizes to small and large .form-selects #34853

Merged
merged 5 commits into from Sep 7, 2021
Merged

Add border-radius sizes to small and large .form-selects #34853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b0950f
Fixes #34852
crdo Aug 31, 2021
a072bcb
Remove fallback
crdo Sep 1, 2021
01be95a
Merge branch 'main' into crdo/issue34852
Sep 1, 2021
97a7063
Merge branch 'main' into crdo/issue34852
XhmikosR Sep 2, 2021
2c270cf
Merge branch 'main' into crdo/issue34852
mdo Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion scss/_variables.scss
View file
Open in desktop
Expand Up @@ -962,7 +962,7 @@ $form-select-feedback-icon-size: $input-height-inner-half $input-height-i

$form-select-border-width: $input-border-width !default;
$form-select-border-color: $input-border-color !default;
$form-select-border-radius: $border-radius !default;
$form-select-border-radius: $input-border-radius !default;
$form-select-box-shadow: $box-shadow-inset !default;

$form-select-focus-border-color: $input-focus-border-color !default;
Expand All @@ -972,10 +972,12 @@ $form-select-focus-box-shadow: 0 0 0 $form-select-focus-width $input-btn-focu
$form-select-padding-y-sm: $input-padding-y-sm !default;
$form-select-padding-x-sm: $input-padding-x-sm !default;
$form-select-font-size-sm: $input-font-size-sm !default;
$form-select-border-radius-sm: $input-border-radius-sm !default;

$form-select-padding-y-lg: $input-padding-y-lg !default;
$form-select-padding-x-lg: $input-padding-x-lg !default;
$form-select-font-size-lg: $input-font-size-lg !default;
$form-select-border-radius-lg: $input-border-radius-lg !default;

$form-select-transition: $input-transition !default;
// scss-docs-end form-select-variables
Expand Down
2 changes: 2 additions & 0 deletions scss/forms/_form-select.scss
View file
Open in desktop
Expand Up @@ -60,11 +60,13 @@
padding-bottom: $form-select-padding-y-sm;
padding-left: $form-select-padding-x-sm;
@include font-size($form-select-font-size-sm);
@include border-radius($form-select-border-radius-sm, 0);
ffoodd marked this conversation as resolved.
Show resolved Hide resolved
}

.form-select-lg {
padding-top: $form-select-padding-y-lg;
padding-bottom: $form-select-padding-y-lg;
padding-left: $form-select-padding-x-lg;
@include font-size($form-select-font-size-lg);
@include border-radius($form-select-border-radius-lg, 0);
}