Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp accordion borders to fix pixel jumping #33149

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Revamp accordion borders to fix pixel jumping #33149

merged 3 commits into from
Mar 17, 2021
+21 −33

Commits on Mar 17, 2021

  1. Revamp accordion borders to fix pixel jumping when toggling 

    - Pushes the borders to the .accordion-item
- Simplifies the .accordion-flush
- Recreates the .accordion-button border-bottom with an inset box-shadow
- Updates background-color to solid to match other components like list group and prevent stacked translucent borders
- Use negative margin to overlap the consecutive items
    @mdo
    mdo committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    bdb455f View commit details
    Browse the repository at this point in the history

  2. Use variable

    @mdo
    mdo committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4fb3d1a View commit details
    Browse the repository at this point in the history

  3. make linter happy, multiple by -1

    @mdo
    mdo committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    e2d3d90 View commit details
    Browse the repository at this point in the history