Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment for escape-svg function #31653

Merged
merged 2 commits into from Sep 15, 2020
Merged

Add a comment for escape-svg function #31653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c131d6d
Add a comment for escape-svg function
mdo Sep 14, 2020
5d993b6
Mention the quotes requirement in the docs too
mdo Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions scss/_functions.scss
View file
Open in desktop
Expand Up @@ -74,6 +74,9 @@
}

// See https://codepen.io/kevinweber/pen/dXWoRw
//
// Requires the use of quotes around data URIs.

@function escape-svg($string) {
@if str-index($string, "data:image/svg+xml") {
@each $char, $encoded in $escaped-characters {
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/5.0/customize/sass.md
View file
Open in desktop
Expand Up @@ -207,7 +207,7 @@ You can also specify a base color with our color map functions:

### Escape SVG

We use the `escape-svg` function to escape the `<`, `>` and `#` characters for SVG background images.
We use the `escape-svg` function to escape the `<`, `>` and `#` characters for SVG background images. When using the `escape-svg` function, data URIs must be quoted.

### Add and Subtract functions

Expand Down