Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore and deprecate make-container-max-widths mixin #31438

Merged
merged 4 commits into from Aug 6, 2020
Merged

Restore and deprecate make-container-max-widths mixin #31438

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4619c9
Restore make-container-max-widths mixin
mdo Aug 5, 2020
99de9c8
Deprecate the `make-container-max-widths` mixin
XhmikosR Aug 6, 2020
fa10cdb
Remove undefined `$ignore-warning`
MartijnCuppens Aug 6, 2020
be645ca
Merge branch 'v4-dev' into max-container-widths
XhmikosR Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions scss/mixins/_grid.scss
View file
Open in desktop
Expand Up @@ -18,6 +18,16 @@
margin-left: -$gutter / 2;
}

// For each breakpoint, define the maximum width of the container in a media query
@mixin make-container-max-widths($max-widths: $container-max-widths, $breakpoints: $grid-breakpoints) {
@each $breakpoint, $container-max-width in $max-widths {
@include media-breakpoint-up($breakpoint, $breakpoints) {
max-width: $container-max-width;
}
}
@include deprecate("The `make-container-max-widths` mixin", "v4.5.2", "v5");
}

@mixin make-col-ready($gutter: $grid-gutter-width) {
position: relative;
// Prevent columns from becoming too narrow when at smaller grid tiers by
Expand Down