v4: drop Node.js < 10 and dev dependency updates #30006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Jan 12, 2020
I agree |
|
I have not checked the diffs, but I agree with the node v6 drop. |
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
from
a69e97f
to
f5dbbf2
Compare
|
Alright, I guess only a few todo are left and @mdo's review |
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
from
67f3c4b
to
1fd3241
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
2 times, most recently
from
cbf8301
to
1fc4d93
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
2 times, most recently
from
8caeddf
to
f482c39
Compare
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
2 times, most recently
from
bfaaec3
to
c8679b8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
2 times, most recently
from
f9873a5
to
00f5b65
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
2 times, most recently
from
97087f6
to
7ea8466
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
from
7ea8466
to
12b0e16
Compare
mdo
approved these changes
Feb 21, 2020
|
@mdo can you adapt the v4-dev branch protection rules? I can't merge without this. |
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
from
f671a31
to
8fb811c
Compare
|
@XhmikosR Done! Sorry for the delay, node 6 and 8 no longer required. |
|
Cool, I'll have another look and merge it after that. So happy to untie us from unsupported Node.js versions :) |
XhmikosR
changed the title
* sinon 8.x doesn't work with IE, so leave it at 7.x.
Johann-S
approved these changes
Mar 9, 2020
XhmikosR
force-pushed
the
v4-dev-xmr-drop-node-6
branch
from
8fb811c
to
bc27e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the engines version from package.json and updates all devDependencies. Also I updated Jekyll to v4.0.0 which is only slightly faster but better than nothing.
In the past we considered such changes breaking ones. I don't think they should be considered breaking ones since they are development only changes. And from now on we should be more lax on master branch anyway.
/CC @twbs/team for feedback.
PS. I will probably rebase this later with further dep updates.
Refs #29821
TODO: