Fix custom file input z-index #26916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry for the lack of confirmation, but thanks @MartijnCuppens 😞 |
mdo
approved these changes
Jul 18, 2018
Closed
|
Thank you for the quick fix, gentlemen! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26912.
What happend?
Box-shadow of custom file inputs are added to the label instead of the input itself. The z-index of the label was increased to overlap buttons (see #26361), but the z-index of the custom file input didn't increase. Therefore the label was clicked and this focuses the file input, but didn't trigger the file browser.
The fix
I've increased the z-index of the custom file input so that the file input works again.
Demo: https://codepen.io/MartijnCuppens/pen/qyaZzv
Tested in latest Chrome/Firefox/IE/Edge/Safari
Kudos to @ysds for adding the ticket number in his commit, this made it a lot easier to find out what was wrong