Fix modal overflow style nesting (#26742) #26743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nest `.modal` styling directly under `.modal-open` to avoid issues when bootstrap is nested.
mdo
approved these changes
Jun 23, 2018
Closed
|
This PR is not good enough If bootstrap supports a usage like #26742: .app {
@import '~bootstrap/scss/bootstrap';
}The current SCSS: .modal-dialog {
...
.modal.fade & {
...
}
.modal.show & {
...
}
}will be compiled: .modal.fade .app .modal-dialog {
...
}
.modal.show .app .modal-dialog {
...
}There are still some similar code in the other components. e.g.: bootstrap/scss/mixins/_buttons.scss Line 38 in da717b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nest
.modalstyling directly under.modal-opento avoid issues when bootstrap is nested.Fixes #26742.