Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate note about color utils #26329

Closed
wants to merge 1 commit into from
Closed

Inaccurate note about color utils #26329

wants to merge 1 commit into from

Conversation

travisdahl
Copy link

@travisdahl travisdahl commented Apr 17, 2018

The docs say:
Note that the .text-white and .text-muted class has no link styling.
but that isn't true, they still have link styling. Either the docs are wrong, or the functionality is wrong. If it's the docs, here is a PR. :)

Hovered over the muted link...
image

Hovered over the white link...
image

@razh
Copy link
Contributor

razh commented Apr 18, 2018

This is in reference to the fact that they do not use the text-emphasis-variant mixin, which adds a hover-color.

.text-white { color: $white !important; }
@each $color, $value in $theme-colors {
@include text-emphasis-variant(".text-#{$color}", $value);
}
.text-body { color: $body-color !important; }
.text-muted { color: $text-muted !important; }

@travisdahl
Copy link
Author

@razh ah. I guess its just a bit unclear then. I consider the underline "link styling". You can close if its a non-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants