Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator for table direct children @5.1.2 #35152

Closed
3 tasks done
PerseusTheGreat opened this issue Oct 9, 2021 · 4 comments
Closed
3 tasks done

Separator for table direct children @5.1.2 #35152

PerseusTheGreat opened this issue Oct 9, 2021 · 4 comments
Labels
Projects

Comments

@PerseusTheGreat
Copy link

PerseusTheGreat commented Oct 9, 2021

Prerequisites

Describe the issue

Hi.
After updating to 5.1.2, in tables that have <colgroup> before <thead>, a border appears above <thead>.
I think the new added rule (#34861) needs to be extended.

Reduced test cases

Current situation:
https://codepen.io/laylazi/pen/MWvWjaM

My proposal:
https://codepen.io/laylazi/pen/dyzypQd

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox, Microsoft Edge

What version of Bootstrap are you using?

5.1.2

@danielmatthew
Copy link

If a <caption> is included too, this causes the <thead>'s top border to render, as .table>:not(:first-child) matches.

See reproduction: https://codepen.io/danielmatthew/pen/zYdROzJ

@ffoodd
Copy link
Member

ffoodd commented Nov 4, 2021

Yup, that's covered by the latest linked PR.

@mbrodala
Copy link
Contributor

mbrodala commented Dec 8, 2021

Since the link is very easy to miss: #35200

@mdo
Copy link
Member

mdo commented Apr 7, 2022

Resolved through #35908.

@mdo mdo closed this as completed Apr 7, 2022
v5.2.0 automation moved this from To do to Done Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants