Skip to content

Commit

Permalink
Tab: minor refactoring (#35511)
Browse files Browse the repository at this point in the history
* remove unneeded parentheses
* move variable
  • Loading branch information
XhmikosR committed Dec 10, 2021
1 parent 871c8bd commit 63d38b1
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions js/src/tab.js
Expand Up @@ -5,12 +5,7 @@
* --------------------------------------------------------------------------
*/

import {
defineJQueryPlugin,
getElementFromSelector,
isDisabled,
reflow
} from './util/index'
import { defineJQueryPlugin, getElementFromSelector, isDisabled, reflow } from './util/index'
import EventHandler from './dom/event-handler'
import SelectorEngine from './dom/selector-engine'
import BaseComponent from './base-component'
Expand Down Expand Up @@ -55,15 +50,15 @@ class Tab extends BaseComponent {

// Public
show() {
if ((this._element.parentNode &&
if (this._element.parentNode &&
this._element.parentNode.nodeType === Node.ELEMENT_NODE &&
this._element.classList.contains(CLASS_NAME_ACTIVE))) {
this._element.classList.contains(CLASS_NAME_ACTIVE)) {
return
}

let previous
const target = getElementFromSelector(this._element)
const listElement = this._element.closest(SELECTOR_NAV_LIST_GROUP)
let previous

if (listElement) {
const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? SELECTOR_ACTIVE_UL : SELECTOR_ACTIVE
Expand All @@ -75,9 +70,7 @@ class Tab extends BaseComponent {
EventHandler.trigger(previous, EVENT_HIDE, { relatedTarget: this._element }) :
null

const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, {
relatedTarget: previous
})
const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { relatedTarget: previous })

if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) {
return
Expand Down

0 comments on commit 63d38b1

Please sign in to comment.