Skip to content

Commit

Permalink
Split table cell padding variables (#30815)
Browse files Browse the repository at this point in the history
  • Loading branch information
mdo committed May 14, 2020
1 parent 5d11d57 commit 46d8763
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
4 changes: 2 additions & 2 deletions scss/_reboot.scss
Expand Up @@ -363,8 +363,8 @@ table {
}

caption {
padding-top: $table-cell-padding;
padding-bottom: $table-cell-padding;
padding-top: $table-cell-padding-y;
padding-bottom: $table-cell-padding-y;
color: $table-caption-color;
text-align: left;
}
Expand Down
4 changes: 2 additions & 2 deletions scss/_tables.scss
Expand Up @@ -24,7 +24,7 @@
// Another advantage is that this generates less code and makes the selector less specific making it easier to override.
// stylelint-disable-next-line selector-max-universal
> :not(caption) > * > * {
padding: $table-cell-padding;
padding: $table-cell-padding-y $table-cell-padding-x;
background-color: var(--bs-table-bg);
background-image: linear-gradient(var(--bs-table-accent-bg), var(--bs-table-accent-bg));
border-bottom-width: $table-border-width;
Expand Down Expand Up @@ -62,7 +62,7 @@
.table-sm {
// stylelint-disable-next-line selector-max-universal
> :not(caption) > * > * {
padding: $table-cell-padding-sm;
padding: $table-cell-padding-y-sm $table-cell-padding-x-sm;
}
}

Expand Down
6 changes: 4 additions & 2 deletions scss/_variables.scss
Expand Up @@ -470,8 +470,10 @@ $mark-bg: #fcf8e3 !default;
// Customizes the `.table` component with basic values, each used across all table variations.

// scss-docs-start table-variables
$table-cell-padding: .5rem !default;
$table-cell-padding-sm: .25rem !default;
$table-cell-padding-y: .5rem !default;
$table-cell-padding-x: .5rem !default;
$table-cell-padding-y-sm: .25rem !default;
$table-cell-padding-x-sm: .25rem !default;

$table-cell-vertical-align: top !default;

Expand Down
1 change: 1 addition & 0 deletions site/content/docs/5.0/migration.md
Expand Up @@ -85,6 +85,7 @@ Changes to Reboot, typography, tables, and more.
- Nested tables do not inherit styles anymore.
- `.thead-light` and `.thead-dark` are dropped in favor of the `.table-*` variant classes which can be used for all table elements (`thead`, `tbody`, `tfoot`, `tr`, `th` and `td`).
- The `table-row-variant()` mixin is renamed to `table-variant()` and accepts only 2 parameters: `$color` (colon name) and `$value` (color code). The border color and accent colors are automatically calculated based on the table factor variables.
- Split table cell padding variables into `-y` and `-x`.
- Dropped `.pre-scrollable` class. [See #29135](https://github.com/twbs/bootstrap/pull/29135)
- `.text-*` utilities do not add hover and focus states to links anymore. `.link-*` helper classes can be used instead. [See #29267](https://github.com/twbs/bootstrap/pull/29267)
- Drop `.text-justify` class. [See #229793](https://github.com/twbs/bootstrap/pull/29793)
Expand Down

0 comments on commit 46d8763

Please sign in to comment.