regression: fully revert attribute title existence

twbs · Sep 6, 2022 · 12e3e60 · 12e3e60
1 parent 6c2c5b9
commit 12e3e60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/js/src/tooltip.js b/js/src/tooltip.js
@@ -509,7 +509,7 @@ class Tooltip extends BaseComponent {
     }
 
     this._element.setAttribute('data-bs-original-title', title) // DO NOT USE IT. Is only for backwards compatibility
-    this._element.removeAttribute('title')
+    this._element.setAttribute('title', '')
   }
 
   _enter() {

diff --git a/js/tests/unit/tooltip.spec.js b/js/tests/unit/tooltip.spec.js
@@ -428,15 +428,15 @@ describe('Tooltip', () => {
 
       const tooltipWithTitleEl = fixtureEl.querySelector('#tooltipWithTitle')
       const tooltip = new Tooltip('#tooltipWithTitle')
-      expect(tooltipWithTitleEl.getAttribute('title')).toBeNull()
+      expect(tooltipWithTitleEl.getAttribute('title')).toBe('')
       tooltip.dispose()
       expect(tooltipWithTitleEl.getAttribute('title')).toBe('tooltipTitle')
 
       const tooltipWithoutTitleEl = fixtureEl.querySelector('#tooltipWithoutTitle')
       const tooltip2 = new Tooltip('#tooltipWithTitle')
       expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull()
       tooltip2.dispose()
-      expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull()
+      expect(tooltipWithoutTitleEl.getAttribute('title')).toBeNull('tooltipTitle')
     })
   })
 
@@ -945,7 +945,7 @@ describe('Tooltip', () => {
         const tooltip = new Tooltip(tooltipEl)
 
         tooltipEl.addEventListener('shown.bs.tooltip', () => {
-          expect(tooltipEl.getAttribute('title')).toBeNull()
+          expect(tooltipEl.getAttribute('title')).toBe('')
           resolve()
         })
         tooltip.show()