Refactor code and update dependencies #187
Conversation
| @@ -4,7 +4,7 @@ on: [push] | |||
|
|
|||
| jobs: | |||
| build-test: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
Hvorfor ikke 22.04 ? 🤔
There was a problem hiding this comment.
Prøver lige af, om det kan lade sig give sig. Jeg mener, der er noget halløj med, at der ikke er php8.2 i det image, som github bruger til ubuntu-22.04
There was a problem hiding this comment.
Narhh, den bliver sur.
actions/runner-images#7545
Så kan man bruge setup-php til at fifle med det selv.
Hvad tænker du er bedst?
| @@ -18,7 +18,7 @@ class Kernel extends HttpKernel | |||
| protected $middleware = [ | |||
| \Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode::class, | |||
| \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class, | |||
| \App\Http\Middleware\TrimStrings::class, | |||
| Middleware\TrimStrings::class, | |||
There was a problem hiding this comment.
Vil det virke? Skal den ikke importes, hvis du fjerner namespace? eller er det noget L11 noget? 😄
There was a problem hiding this comment.
Kernel er i App\Http-namespace, så burde den ikke fint kunne komme videre derfra? :)
| @@ -235,22 +237,22 @@ public function getBill(string $start_date, string $end_date, string $price_area | |||
| } | |||
|
|
|||
| if (array_key_exists('Spotpris', $bill)) { | |||
| if (Carbon::parse($hour, 'Europe/Copenhagen')->lessThanOrEqualTo(Carbon::parse()->now()->startOfHour())) { | |||
| if (Carbon::parse($hour, 'Europe/Copenhagen')->lessThanOrEqualTo(Carbon::now()->startOfHour())) { | |||
There was a problem hiding this comment.
eller bare now()->startOfHour()
negoziator
force-pushed
the
feature/laravel11
branch
from
0d4737a
to
e26c6ed
Compare
No description provided.