Use electron scoped ipc #5165
Merged
Use electron scoped ipc #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganthern
force-pushed
the
use-electron-ipc-4848
branch
from
ae84922
to
09f6d11
Compare
our bookkeeping is not necessary anymore since each webContents has its own scoped IpcMain instance now. close #4848
ganthern
force-pushed
the
use-electron-ipc-4848
branch
from
09f6d11
to
d32ce72
Compare
charlag
approved these changes
Feb 23, 2023
| @@ -667,7 +666,7 @@ export class List<ElementType extends ListElement, RowType extends VirtualRow<El | |||
| shiftPressed = false | |||
| } | |||
|
|
|||
| if (shiftPressed && this.lastMultiSelectWasKeyUp === true && this.selectedEntities.length > 1) { | |||
| if (shiftPressed && this.lastMultiSelectWasKeyUp && this.selectedEntities.length > 1) { | |||
There was a problem hiding this comment.
whoops. I haphazardly pulled this out of my indexing investigation branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4848