Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace our per-window ipc with webContents.ipc #4848

Closed
1 task done
ganthern opened this issue Dec 13, 2022 · 0 comments · Fixed by #5165
Closed
1 task done

replace our per-window ipc with webContents.ipc #4848

ganthern opened this issue Dec 13, 2022 · 0 comments · Fixed by #5165
Assignees
@vitoreiji
Labels
desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup state:tested We tested it and are about to release it
Milestone
3.109.13

Comments

@ganthern
Copy link
Contributor

ganthern commented Dec 13, 2022 •
edited by vitoreiji

electron 22 introduced a new ipc API that we could use to remove some code:

electron/electron#34959

Test Notes

  • using the app, logging in, indexing while having multiple windows open still works
@ganthern ganthern added desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup labels Dec 13, 2022
@ganthern ganthern added this to the Technical tasks milestone Dec 13, 2022
@ganthern ganthern modified the milestones: Technical tasks, 3.109.5+ Feb 22, 2023
ganthern added a commit that referenced this issue Feb 23, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
ae84922 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
@ganthern ganthern mentioned this issue Feb 23, 2023
Merged
ganthern added a commit that referenced this issue Feb 23, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
09f6d11 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
ganthern added a commit that referenced this issue Feb 23, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
d32ce72 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
@ganthern ganthern added the state:done meets our definition of done label Feb 23, 2023
ganthern added a commit that referenced this issue Feb 23, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
8816c12 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
@vitoreiji vitoreiji self-assigned this Feb 28, 2023
@ganthern ganthern added state:tested We tested it and are about to release it and removed state:done meets our definition of done labels Feb 28, 2023
ganthern added a commit that referenced this issue Mar 1, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
a539cae 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
ganthern added a commit that referenced this issue Mar 2, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
e6108f7 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
ganthern added a commit that referenced this issue Mar 28, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
12f7df3 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
ganthern added a commit that referenced this issue Apr 17, 2023
@ganthern
remove CentralIpcHandler and use webContents.ipc
5c19101 
our bookkeeping is not necessary anymore since each webContents has
its own scoped IpcMain instance now.

close #4848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitoreiji vitoreiji

Labels
desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.109.13
Development

Successfully merging a pull request may close this issue.

Use electron scoped ipc tutao/tutanota
2 participants
@vitoreiji @ganthern