Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consumer not restarting on retriable connection errors #1304

Merged
merged 4 commits into from
May 2, 2022
Merged

Fix consumer not restarting on retriable connection errors #1304

merged 4 commits into from
May 2, 2022

Commits on Mar 7, 2022

  1. Change wrapping errors to implement Error cause spec 

    This deprecates the old `originalError` property and
replaces it with `cause`. See https://tc39.es/proposal-error-cause/
    @Nevon
    Nevon committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4acf278 View commit details
    Browse the repository at this point in the history

  2. Unwrap original error cause when determining whether to crash 

    KafkaJSNumberOfRetriesExceeded and KafkaJSNonRetriableError are
not retriable, but we still want to allow the user to restart the
consumer if the original error was retriable. Because we can have
a KafkaJSNumberOfRetriesExceeded error as the cause of a
KafkaJSNonRetriableError, we need to unwrap that to get the original
error.

Fixes #1299
    @Nevon
    Nevon committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fb19164 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'master' into fix-retries-1299

    @Nevon
    Nevon committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    7d62e08 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Merge branch 'master' of github.com:tulios/kafkajs into fix-retries-1299

    @Nevon
    Nevon committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d67b22e View commit details
    Browse the repository at this point in the history