Fix consumer not restarting on retriable connection errors #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the old `originalError` property and replaces it with `cause`. See https://tc39.es/proposal-error-cause/
KafkaJSNumberOfRetriesExceeded and KafkaJSNonRetriableError are not retriable, but we still want to allow the user to restart the consumer if the original error was retriable. Because we can have a KafkaJSNumberOfRetriesExceeded error as the cause of a KafkaJSNonRetriableError, we need to unwrap that to get the original error. Fixes #1299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situation, a
KafkaJSNumberOfRetriesExceedederror can be the cause of aKafkaJSNonRetriableError. In that case, the consumer would not correctly determine whether or not it should restart or permanently crash.So, to figure out if we should allow the consumer to restart, we now unwrap the error to get the retriability of the original error instead of just the top-level error.
Fixes #1299