Don't set servername if host is an IP

See https://nodejs.org/api/deprecations.html#DEP0123 Fixes #1407
tulios · Jul 25, 2022 · d0ac51e · d0ac51e
1 parent a0ef955
commit d0ac51e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/network/socketFactory.js b/src/network/socketFactory.js
@@ -9,7 +9,10 @@ module.exports = () => {
 
   return ({ host, port, ssl, onConnect }) => {
     const socket = ssl
-      ? tls.connect(Object.assign({ host, port, servername: host }, ssl), onConnect)
+      ? tls.connect(
+          Object.assign({ host, port }, !net.isIP(host) ? { servername: host } : {}, ssl),
+          onConnect
+        )
       : net.connect({ host, port }, onConnect)
 
     socket.setKeepAlive(true, KEEP_ALIVE_DELAY)