Fix --platform case sensitivity with test and build commands #6268
+59
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
approved these changes
May 9, 2024
waltflanagan
force-pushed
the
FlexiblyPlatformSepcification
branch
from
752df47
to
873683a
Compare
fortmarek
approved these changes
May 10, 2024
Comment on lines
+38
to
+45
| do { | ||
| let _ = try Platform.from(commandLineValue: "not_a_platform") | ||
| XCTFail("Expected erro to be thrown") | ||
| } catch let error as UnsupportedPlatformError { | ||
| XCTAssertEqual(error, UnsupportedPlatformError(input: "not_a_platform")) | ||
| } catch { | ||
| XCTFail("Unexpected error thrown") | ||
| } |
There was a problem hiding this comment.
You can use XCTAssertThrowsSpecific that does the try-catch dance for you
fortmarek
added
the
changelog:fixed
pepicrft
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed based on user feedback that
--platform iOSdoesn't work. It should. So lets lowercase our input and provide better messaging if we get an invalid value.How to test the changes locally 🧐
Run
tuist buildwith various values for--platformContributor checklist ✅
mise run lint:fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry