Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align bundle name with dashes sanitizing with SPM #6265

Conversation

danibachar
Copy link
Collaborator

Short description 📝

When creating bundle target, the product name diverage from the target name, as we used to pass nil (then the code use the target name and replace dash ("-") with underscore ("_")
This is different then how SPM is naming bundles etc

How to test the changes locally 🧐

See newly added test

Contributor checklist ✅

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@danibachar danibachar changed the title Fix issue where bundle target name and product name diverge due to re… Fix issue where bundle target name and product name for generated bundle targets May 9, 2024
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thanks!

We can merge this once the pipeline goes through. Might be worth rerunning as it seems there's some flakiness right now.

@danibachar
Copy link
Collaborator Author

danibachar commented May 9, 2024

Not sure what is happening, mise install stage fails, and all jobs are failing due to it...
BTW - I couldn't re-run and job (It shows me the following message and does nothing, so I had to push a commit

Screenshot 2024-05-09 at 9 57 34 AM

@fortmarek
Copy link
Member

Looks like updating to latest main fixed the issues with CI (or it might have been temporary flakiness). Either way, merging, thanks for this contribution!

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label May 14, 2024
@fortmarek fortmarek changed the title Fix issue where bundle target name and product name for generated bundle targets Align bundle name with dashes sanitizing with SPM May 14, 2024
@fortmarek fortmarek merged commit 1cbbec0 into tuist:main May 14, 2024
8 checks passed
@danibachar danibachar deleted the daniebachar/fix-bundle-target-product-name-same-as-target-name branch May 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants