Fix integration of SPM packages with spaces in their name #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
reviewed
May 9, 2024
Comment on lines
295
to
299
| let sanitizedPackageName = if packageInfo.name.contains(" ") { | ||
| "\"\(packageInfo.name)\"" | ||
| } else { | ||
| packageInfo.name | ||
| } |
There was a problem hiding this comment.
Can we add a test for this in the PackageInfoMapperTests?
There was a problem hiding this comment.
I've added a new test to PackageInfoMapperTests, it's hopefully what you expect )))
kapitoshka438
force-pushed
the
fix-package-name-if-spaces
branch
from
eebdbdf
to
af1be2a
Compare
6 tasks
fortmarek
approved these changes
May 14, 2024
fortmarek
changed the title
fortmarek
added
the
changelog:fixed
|
Amazing contribution 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
If a package contains space symbols in its name, PackageInfoMapper produces invalid Swift flags, making compiler recognize words as separate flags:
OTHER_SWIFT_FLAGS = "$(inherited) -package-name Mobile Buy SDK";This PR fixes this by enclosing such names inside quotes:
OTHER_SWIFT_FLAGS = "$(inherited) -package-name \"Mobile Buy SDK\"";This PR adds a new fixture
ios_app_with_spm_dependencieswith an application target that depends on Mobile Buy SDKContributor checklist ✅
mise run lint:fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry