Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultConfiguration generation option to Config.swift #6255

Merged
merged 1 commit into from May 14, 2024

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented May 6, 2024

Related: #6248

Short description πŸ“

Adds an option to specify a default configuration in your Config.swift. We currently use for caching and fetching binaries the first (when alphabetically sorted) debug configuration. As that might not be the desired configuration, we're adding the option to configure the default.

How to test the changes locally 🧐

You can play with the new app_with_custom_default_configuration fixture.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:added PR will be listed in the Added section of CHANGELOG label May 6, 2024
@fortmarek fortmarek marked this pull request as ready for review May 6, 2024 14:17
@fortmarek fortmarek requested a review from pepicrft May 6, 2024 20:50
@fortmarek fortmarek merged commit 7e474a2 into main May 14, 2024
8 checks passed
@fortmarek fortmarek deleted the config/default-configuration branch May 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added PR will be listed in the Added section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants