New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not automatically add -ObjC flag when integrating Objective-C dependencies #6244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 we'll try to add manually where needed. Still seems to me Apple has some other built in behavior in SPM that makes things work even without this flag, so pretty interesting what that could be |
@fortmarek absolutely, coming back to this today @freak4pc can you confirm which of your dependencies are running into this and see if any of the other resolutions mentioned in #6243 work? Happy to chat over Slack as well to see if we can identify any other patterns/resoloutions. I am definitely curious as to why this seems to work with SPM but Apple definitely does some funky linking things there. Yet, some docs (like Firebase) seemed to say it was needed for SPM. I do think the best long term strategy is for Tuist to support something similar to Bazel's |
This reverts commit 9297022.
8bc3ef9
to
e50e257
Compare
The issued was with GoogleSignIn, IMO. I'll see if we have some time to debug this anytime soon. |
fixtures/app_with_spm_dependencies/App/Sources/AppKit/AppKit.swift
Outdated
Show resolved
Hide resolved
970bcc0
to
a61ffce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very onboard with this change @thedavidharris. Until today, I had been using that flag without 100% understanding the role that it played when compiling Objective-C code. I think the documentation update should be sufficient for developers to understand any issue arising from their integration with Objective-C code, and since we allow overriding the build settings, I think we are all good.
a61ffce
to
8dbd8b3
Compare
8dbd8b3
to
bba8f66
Compare
This reverts commit 9297022.
Resolves #6243
Short description 📝
This reverts a change that automatically places
-ObjC
compiler flags with no opt-out behavior. This can cause issues in projects and make them unbuildable or bloat their binary size unnecessarily.How to test the changes locally 🧐
Test with
app_with_spm_dependencies
fixture and see that the-ObjC
flag is not automatically addedContributor checklist ✅
mise run lint:fix
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry