New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persists the generated Edit project in the user's .cache directory #6056
base: main
Are you sure you want to change the base?
Conversation
…rvice and utilized it in the EditService instead of generating a temporary directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this one @jgoodrick. I left some minor comments. We can merge the PR once they are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be definitely a great UX improvement 😌
…ns a non-optional Xcode, and throws if none is found
…e to surface the XcodeVersionError.noXcode where it was previously unwrapped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋
Sorry for not re-reviewing this PR in a timely manner. The implementation looks good but would you mind adding a couple of unit tests? A new behavior without any raises a red flag 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we currently don't have tests for this service but can we add some?
This is a naive implementation of caching the manifests project. There may be a hashing strategy that is already in use, but I wasn't aware of it yet, if so. That could probably be improved.
In response to: #5828
How to test the changes locally 🧐
Contributor checklist ✅
mise run lint:fix
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry