Reduce max distance moved for long taps (#730)

At 10 pixels, it was too easy to accidentally ping while dragging around
ttbud · Aug 6, 2021 · 2aa12fc · 2aa12fc
1 parent bc63842
commit 2aa12fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/web/src/ui/util/useLongTap.test.tsx b/web/src/ui/util/useLongTap.test.tsx
@@ -35,7 +35,7 @@ it("does not trigger for drags", async () => {
   const { getByText } = render(<LongTapTest onLongTap={cb} />);
   const target = getByText("Touch Target");
   await tap(target, { action: "down", pos: { x: 0, y: 0 } });
-  await fireEvent.pointerMove(target, {
+  fireEvent.pointerMove(target, {
     pointerType: "touch",
     isPrimary: true,
     clientX: MAX_MOVE_LONG_TAP_PX + 1,

diff --git a/web/src/ui/util/useLongTap.ts b/web/src/ui/util/useLongTap.ts
@@ -3,7 +3,7 @@ import { assert } from "../../util/invariants";
 import Pos2d, { distance } from "../../util/shape-math";
 
 // Maximum distance in pixels your finger can move to still be considered a long tap
-export const MAX_MOVE_LONG_TAP_PX = 10;
+export const MAX_MOVE_LONG_TAP_PX = 5;
 export const LONG_TAP_MS = 250;
 
 interface State {