New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nodenext moduleResolution #149
Merged
sindresorhus
merged 5 commits into
tsdjs:main
from
perrin4869:feature/module-resolution-nodex
Jun 30, 2022
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
source/test/fixtures/module-resolution/node16-from-package-json/index.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
declare const foo: string; | ||
|
||
export default foo; |
1 change: 1 addition & 0 deletions
1
source/test/fixtures/module-resolution/node16-from-package-json/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports.default = "foo"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use single-quotes. |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/node16-from-package-json/index.test-d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import foo from "foo"; | ||
import {expectType} from '../../../..'; | ||
|
||
expectType<string>(foo); |
9 changes: 9 additions & 0 deletions
9
source/test/fixtures/module-resolution/node16-from-package-json/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "foo", | ||
sindresorhus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"exports": "./index.js", | ||
"tsd": { | ||
"compilerOptions": { | ||
"module": "node16" | ||
} | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
source/test/fixtures/module-resolution/node16-from-tsconfig-json/index.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
declare const foo: string; | ||
|
||
export default foo; |
1 change: 1 addition & 0 deletions
1
source/test/fixtures/module-resolution/node16-from-tsconfig-json/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports.default = "foo"; |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/node16-from-tsconfig-json/index.test-d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import foo from "foo"; | ||
import {expectType} from '../../../..'; | ||
|
||
expectType<string>(foo); |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/node16-from-tsconfig-json/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "foo", | ||
"exports": "./index.js" | ||
} |
5 changes: 5 additions & 0 deletions
5
source/test/fixtures/module-resolution/node16-from-tsconfig-json/tsconfig.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"compilerOptions": { | ||
"module": "node16" | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
source/test/fixtures/module-resolution/nodenext-from-package-json/index.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
declare const foo: string; | ||
|
||
export default foo; |
1 change: 1 addition & 0 deletions
1
source/test/fixtures/module-resolution/nodenext-from-package-json/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports.default = "foo"; |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/nodenext-from-package-json/index.test-d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import foo from "foo"; | ||
import {expectType} from '../../../..'; | ||
|
||
expectType<string>(foo); |
9 changes: 9 additions & 0 deletions
9
source/test/fixtures/module-resolution/nodenext-from-package-json/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "foo", | ||
"exports": "./index.js", | ||
"tsd": { | ||
"compilerOptions": { | ||
"module": "nodenext" | ||
} | ||
} | ||
} |
3 changes: 3 additions & 0 deletions
3
source/test/fixtures/module-resolution/nodenext-from-tsconfig-json/index.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
declare const foo: string; | ||
|
||
export default foo; |
1 change: 1 addition & 0 deletions
1
source/test/fixtures/module-resolution/nodenext-from-tsconfig-json/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports.default = "foo"; |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/nodenext-from-tsconfig-json/index.test-d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import foo from "foo"; | ||
import {expectType} from '../../../..'; | ||
|
||
expectType<string>(foo); |
4 changes: 4 additions & 0 deletions
4
source/test/fixtures/module-resolution/nodenext-from-tsconfig-json/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "foo", | ||
"exports": "./index.js" | ||
} |
5 changes: 5 additions & 0 deletions
5
source/test/fixtures/module-resolution/nodenext-from-tsconfig-json/tsconfig.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"compilerOptions": { | ||
"module": "nodenext" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -138,6 +138,30 @@ test('allow specifying a lib in tsconfig.json', async t => { | |||||
verify(t, diagnostics, []); | ||||||
}); | ||||||
|
||||||
test('use moduleResolution NodeNext when module is nodenext in tsconfig.json', async t => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/module-resolution/nodenext-from-tsconfig-json')}); | ||||||
|
||||||
verify(t, diagnostics, []); | ||||||
}); | ||||||
|
||||||
test('use moduleResolution NodeNext when module is nodenext in package.json', async t => { | ||||||
const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/module-resolution/nodenext-from-package-json')}); | ||||||
|
||||||
verify(t, diagnostics, []); | ||||||
}); | ||||||
|
||||||
test('use moduleResolution Node16 when module is node16 in tsconfig.json', async t => { | ||||||
const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/module-resolution/node16-from-tsconfig-json')}); | ||||||
|
||||||
verify(t, diagnostics, []); | ||||||
}); | ||||||
|
||||||
test('use moduleResolution Node16 when module is node16 in package.json', async t => { | ||||||
const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/module-resolution/node16-from-package-json')}); | ||||||
|
||||||
verify(t, diagnostics, []); | ||||||
}); | ||||||
|
||||||
test('add support for esm with esModuleInterop', async t => { | ||||||
const diagnostics = await tsd({ | ||||||
cwd: path.join(__dirname, 'fixtures/esm') | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to explain this using a code comment on line 139