Report the number of evaluated tests alongside with diagnostics #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/tsd into feature/verbose-reporting
Co-authored-by: Sam Verschueren <sam.verschueren@gmail.com>
mrazauskas
commented
Oct 13, 2021
| @@ -94,6 +109,7 @@ export const getDiagnostics = (context: Context): Diagnostic[] => { | |||
| .concat(program.getSyntacticDiagnostics()); | |||
|
|
|||
| const assertions = extractAssertions(program); | |||
| const testCount = countAssertions(assertions); | |||
There was a problem hiding this comment.
Might be named assertionCount as well.
This was referenced Oct 14, 2021
|
Not good idea. It reports count of assertions, not count of tests (there are no tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased and cleaned up of stale #75.
My motivation is simply to make it possible to use
tsdwithjest.PS I couldn’t find a way to work directly on #75. New PR seemed to be the solution. If this is somehow non-nonethical or a bad practise, I am fine to close and to proceed in some other way.