Support Kotlin 1.9.0 #388
Merged
Support Kotlin 1.9.0 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoD
commented
Aug 8, 2023
| @@ -36,8 +36,9 @@ abstract class AbstractKotlinCompilation<A : CommonCompilerArguments> internal c | |||
| /** Working directory for the compilation */ | |||
| var workingDir: File by default { | |||
| val path = Files.createTempDirectory("Kotlin-Compilation") | |||
| log("Created temporary working directory at ${path.toAbsolutePath()}") | |||
| return@default path.toFile() | |||
| val canonicalFile = path.toFile().canonicalFile | |||
There was a problem hiding this comment.
The JS compiler calls .canonicalFile internally - at least on MacOS that may be different to the absolute path (/private/var/… vs /var/…), which made the tests fail.
BoD
commented
Aug 8, 2023
| @@ -91,7 +95,7 @@ class KotlinJsCompilation : AbstractKotlinCompilation<K2JSCompilerArguments>() { | |||
| args.irOnly = irOnly | |||
| args.irModuleName = irModuleName | |||
| args.generateDts = generateDts | |||
| args.useDeprecatedLegacyCompiler = useDeprecatedLegacyCompiler | |||
| args.forceDeprecatedLegacyCompilerUsage = useDeprecatedLegacyCompiler | |||
There was a problem hiding this comment.
useDeprecatedLegacyCompiler was removed here
BoD
commented
Aug 8, 2023
| @@ -78,27 +78,6 @@ class KotlinJsCompilationTests { | |||
| assertThat(jsFile.readText()).contains("function KSource_0() {") | |||
| } | |||
|
|
|||
| @Test | |||
Closed
Closed
|
In this PR can we remove the call in |
|
@apatrida I've just pushed a commit to remove |
BoD
commented
Sep 26, 2023
| @@ -71,6 +71,7 @@ class KotlinCompilation : AbstractKotlinCompilation<K2JVMCompilerArguments>() { | |||
| var javaParameters: Boolean = false | |||
|
|
|||
| /** Use the IR backend */ | |||
| @Deprecated("Since Kotlin 1.9.20 this option is no longer supported by the compiler. It has no effect.") | |||
There was a problem hiding this comment.
Removed in this commit.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #380 (and closes #379).
Let's see if I have better luck with Windows tests.