Add support for fs.watch(). #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This support currently only works for Node v10 and newer, since the fs_event_wrap native binding is lazy-loaded and thus can be pre-patched before first use. To make this robust enough to actually use, it may be necessary to also add in monkeypatching of the fs.watch endpoint. The tests are incomplete; mainly just enough to demonstrate that this works as a proof of concept.
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support currently only works for Node v10 and newer, since the
fs_event_wrap native binding is lazy-loaded and thus can be pre-patched
before first use.
To make this robust enough to actually use, it may be necessary to also
add in monkeypatching of the fs.watch endpoint.
The tests are incomplete; mainly just enough to demonstrate that this
works as a proof of concept.