test: nodejs v14+ silently ignores closing closed file descriptor

tschaub · Mar 16, 2021 · 91e85c2 · 91e85c2
1 parent 819f809
commit 91e85c2
Showing 1 changed file with 24 additions and 19 deletions.
diff --git a/test/lib/fs.open-close.spec.js b/test/lib/fs.open-close.spec.js
@@ -6,6 +6,7 @@ const mock = require('../../lib/index');
 
 const assert = helper.assert;
 const withPromise = helper.withPromise;
+const inVersion = helper.inVersion;
 
 describe('fs.open(path, flags, [mode], callback)', function() {
   beforeEach(function() {
@@ -220,25 +221,29 @@ describe('fs.close(fd, callback)', function() {
     });
   });
 
-  withPromise.it('promise fails for closed file descriptors', function(done) {
-    fs.promises
-      .open('dir/file.txt', 'w')
-      .then(function(fd) {
-        return fd.close().then(function() {
-          return fd.close();
-        });
-      })
-      .then(
-        function() {
-          done(new Error('should not succeed.'));
-        },
-        function(err) {
-          assert.instanceOf(err, Error);
-          assert.equal(err.code, 'EBADF');
-          done();
-        }
-      );
-  });
+  inVersion('>=10.0.0 <14.0.0').it(
+    'promise fails for closed file descriptors',
+    function(done) {
+      fs.promises
+        .open('dir/file.txt', 'w')
+        .then(function(fd) {
+          return fd.close().then(function() {
+            // in Nodejs v14+, closing on closed file descriptor is silently ignored.
+            return fd.close();
+          });
+        })
+        .then(
+          function() {
+            done(new Error('should not succeed.'));
+          },
+          function(err) {
+            assert.instanceOf(err, Error);
+            assert.equal(err.code, 'EBADF');
+            done();
+          }
+        );
+    }
+  );
 });
 
 describe('fs.closeSync(fd)', function() {