Remove jcenter repository #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
Coverage 75.67% 75.67%
+ Complexity 316 8 -308
==========================================
Files 54 54
Lines 2689 2689
Branches 428 428
==========================================
Hits 2035 2035
Misses 329 329
Partials 325 325
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ashutoshgngwr
requested changes
Oct 15, 2021
There was a problem hiding this comment.
This is good! Thanks for taking the time to perform the migration. I think it's about time we upgraded ExoPlayer despite its gapless issue on a few devices.
Although, it needs a change so that the build can proceed.
| @@ -115,11 +115,11 @@ dependencies { | |||
| implementation 'androidx.recyclerview:recyclerview:1.2.1' | |||
| implementation 'com.github.AppIntro:AppIntro:6.1.0' | |||
| implementation 'io.github.medyo:android-about-page:2.0.0' | |||
| implementation 'com.google.android.exoplayer:exoplayer-core:2.11.8' | |||
| implementation 'com.google.android:flexbox:2.0.1' | |||
| implementation 'com.google.android.exoplayer:exoplayer-core:2.13.3' | |||
There was a problem hiding this comment.
ashutoshgngwr
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the now deprecated jcenter from the project and migrate / update all dependencies which are only available on jcenter.
Testing
Dependencies that have been updated / changed:
ExoPlayer
Update to
v2.13.3. It is available on Google maven starting with release 2.13.3.Source: https://mvnrepository.com/artifact/com.google.android.exoplayer/exoplayer
Flexbox
Updated to
v3.0.0. Has been moved to google maven starting with version 3.0.0. Group ID was changed fromcom.google.android tocom.google.android.flexbox`Source: https://github.com/google/flexbox-layout/releases/tag/3.0.0
Flextools
Updated to
v1.0.3. Group ID has been changed fromcom.hopenlib.librarytoio.github.mrherintsoahasinafuring migration to mavenCentral:Compare v1.0.1 with v1.0.3.
Source: https://github.com/mrHerintsoaHasina/flextools/releases/tag/v1.0.3
Falcon
Edit: Falcon has been updated in screengrab v2.1.1
Transitive dependencie to
screengrab v2.1.0(latest version). Has been moved to mavenCentral starting with v2.2.0.Source: https://github.com/jraska/Falcon/releases/tag/2.2.0
This transitive dependency has been manually overriden since no new release of screengrab is available, yet. The constraint can be removed once a new version of screengrab is released.
I created an issue for this on the fastlane repository.