Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect more osx variants #67

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Detect more osx variants #67

merged 1 commit into from
Nov 7, 2022

Conversation

trustin
Copy link
Owner

@trustin trustin commented Nov 7, 2022

Motivation:

It looks like some JDK implementations do neither return macosx or osx for System.getProperty("os.arch").

Modifications:

  • Return osx when os.arch starts with mac instead of macosx, so that the plugin detects both mac and macosx.

Result:

Motivation:

It looks like some JDK implementations do neither return `macosx` or
`osx` for `System.getProperty("os.arch")`.

Modifications:

- Return `osx` when `os.arch` starts with `mac` instead of `macosx`,
  so that the plugin detects both `mac` and `macosx`.

Result:

- Fixes #58
@trustin trustin added this to the 1.7.1 milestone Nov 7, 2022
@trustin trustin merged commit 88bae1e into master Nov 7, 2022
@trustin trustin deleted the more_mac_os_names branch November 7, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected os.name when running on Apple Silicon M1
1 participant