Initial import, plus http status code updates #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in the original repo they have a go.mod and go.sum in the test
directory that aren't in ours. Should those be included too? If not, maybe a comment in the README indicating that they shouldn't and a reason would be good for future us when we try updating this with any changes they've made.
(import (builtins.fetchGit { | ||
# Descriptive name to make the store path easier to identify | ||
name = "act-0.2.24"; | ||
url = "https://github.com/NixOS/nixpkgs/"; | ||
ref = "refs/heads/nixpkgs-unstable"; | ||
rev = "a1de1fc28b27da87a84a0b4c9128972ac4a48193"; | ||
}) {}).act |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool, I didn't realize this was a thing. Should we have something in the README to showcase using it, or a script (or Makefile, though I know there's plenty of issues with those) that will run it for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added something to the README
[otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/net/http/otelhttp) | ||
|
||
as of [v.0.26.1](https://github.com/open-telemetry/opentelemetry-go-contrib/commit/7876cd14dc5f09765205caa0fb420fafe23141aa) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add setup instructions? Especially for non-nix users since they'll have to make sure go
and pre-commit
are set up correctly. Well even nix
users will need to install pre-commit
hooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a blurb to the README
Oh also, I don't really know much about licenses. I know we pulled this into it's own repo because of the license difference and that several of the files have the license blurb at the top of the file, but do we also need to include a repo-level license? |
Co-authored-by: Felipe Lee <35938642+felipe-lee@users.noreply.github.com>
Thank you. I copied the LICENSE from the original repo |
README updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for making those updates. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question this repo doesn't look like a fork of the original, is there a reason we couldn't have done that?
@gidjin I think that's what @ahobson was mentioning with this:
So I think the goal is by only keeping up with a single package it can make it easier to maintain. Though I guess one question is, how we plan on keeping up to date. Though hopefully we won't need to for too long |
I mean, the reason for the fork is that the folks are not updating the original with PRs we need. It seems to me like we'll have one of two outcomes:
|
Create a new otelhttp repo.
We aren't importing the entirety of go-opentelemetry-contrib because we want to enforce go linting rules and don't want to have to update the entire repository.
This PR includes changes from open-telemetry/opentelemetry-go-contrib#771