Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade notify from v5 to v4 #350

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Downgrade notify from v5 to v4 #350

merged 2 commits into from
Apr 13, 2022

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Apr 12, 2022

This downgrades the notify crate back from v5 to v4 as the latest version is still missing some important features. Especially event debouncing is missing, which causes multiple compiles on file save in VSCode and Emacs. Sticking with v4 seems to be the recommended way from the maintainers as well.

This might eventually help fixing the issues with Vim too.

Also, see #232, #331.

Fixes #238

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).
  • Updated site content with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 馃.

Copy link
Member

@thedodd thedodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 seems reasonable. I think I've historically already flopped between v4 & v5 once before haha. Oh well. IIRC, the only reason I tried to move away from v4 was due to the sync interface ... but it is not a big deal.

@dnaka91
Copy link
Contributor Author

dnaka91 commented Apr 12, 2022

Thanks, @thedodd. I wasn't a big fan of pulling the std::sync::mpsc channel back in, neither. Even have to start up an extra thread just to forward messages to the async channel.

But it helps with the linked issues.

Seeing some activity on the notify crate's repo as well, so hopes are we maybe can get a full v5 release this year. Might open an issue on their site, asking for a new v4 release that just updates the dependencies. As it stands, this introduces quite a bit of dependency duplicates (luckily no public API facing ones).

@dnaka91 dnaka91 merged commit ef96039 into master Apr 13, 2022
@dnaka91 dnaka91 deleted the notify-v4 branch April 13, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving file in VSCode emitting two change events causing Trunk to build twice
2 participants