Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some of the most common php tooling #757

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

matthewbaggett
Copy link
Contributor

  • phpunit for running unittests
  • paratest for running the same unitests in parallel
  • php-cs-fixer for enforcing formatting.

php-cs-fixer could be considered to be promoted to being a linter as soon as I work out how to parse its output and feed it through a post-processor like phpstan is.

… tests, paratest for running the same unitests in parallel, and php-cs-fixer for enforcing formatting. php-cs-fixer could be considered to be promoted to being a linter as soon as I work out how to parse its output and feed it through a post-processor like phpstan is
Copy link

trunk-io bot commented Apr 26, 2024

⏱️ 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
CodeQL-Build 1m 🟩
Trunk Check runner [linux] 1m 🟩
Windows Tool Tests 48s 🟥
Repo Tests / Plugin Tests 39s 🟩
Tool Tests (ubuntu-latest) 33s 🟥
Tool Tests (macOS) 13s 🟥
Detect changed files 7s 🟩
Aggregate Test Results 1s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

@laurit17 laurit17 self-requested a review April 26, 2024 18:29
@laurit17
Copy link
Contributor

Hi Matthew, thank you so much for taking the lead here on integrating these tools. In order to get them to pass, would you mind adding health checks and unit tests? You can look at These are very simple. Let me/us know if you have any trouble.

I'd do it myself but you're using a fork, not a branch :)

example: https://github.com/trunk-io/plugins/blob/main/tools/clangd/plugin.yaml#L20

@EliSchleifer
Copy link
Member

@matthewbaggett - thanks for opening this pull request. would love to get these landed. do you need more guidance to get the tests in place?

@EliSchleifer EliSchleifer requested review from EliSchleifer and TylerJang27 and removed request for laurit17 May 13, 2024 18:07
@TylerJang27
Copy link
Collaborator

Hi @matthewbaggett! We'd like to get more php usage in soon, so I'll push some basic testing code to your branch or to a fork by the end of the week to try and get this in

@TylerJang27
Copy link
Collaborator

@matthewbaggett I've gone and added the dependencies and tests to get this working. Can you try php-cs-fixer out and make sure it conforms to your original needs/idiomatic usage? Otherwise I will land this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants