feat: add default config for stylelint #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJang27
reviewed
Mar 22, 2023
There was a problem hiding this comment.
For [lack of forethought and for simplicity] reasons, all test input files must have different prefixes, even if they have different file extensions. Please rename one of these. I usually prefix as basic_py, or similar. You'll notice that none of these snapshots contain "basic.in.sass" for this reason.
Comment on lines
+3
to
+12
| # When enabling stylelint, you should also add the stylelint plugin configs, | ||
| # like so: | ||
| # | ||
| # lint: | ||
| # enabled: | ||
| # - stylelint@15.3.0: | ||
| # packages: | ||
| # - stylelint-config-standard@31.0.0 | ||
| # - stylelint-config-standard-scss@7.0.1 | ||
| # |
There was a problem hiding this comment.
I understand that this is strictly an improvement, but I'm not sure if this is discoverable enough. Thoughts on moving this to a linters/stylelint-level readme or perhaps somewhere else?
| # packages: | ||
| # - stylelint-config-standard@31.0.0 | ||
| # - stylelint-config-standard-scss@7.0.1 | ||
| # | ||
| definitions: |
There was a problem hiding this comment.
Because you've added a direct config, you must set is_recommended: false (this is causing the repo_tests failure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make stylelint work with scss