This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: Pass enableMemory: true when requesting traces
#4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
requested review from
gnidan,
cds-amal,
tenthirtyone,
dongmingh and
sukanyaparashar
cds-amal
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Looks good. Nice work sleuthing this change @haltman-at ! Hopefully the official GETH docs will soon reflect changes in GETH PR 23558
Lets see how tests come back :)
|
Yeah, the tests of course are just testing it with Ganache 6... I also manually tested it with Ganache 7, and, obviously, with Geth itself, both newer versions that have the problem and older versions that don't. I skipped erigon and besu testing, as mentioned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4565. It turns out you can pass
enableMemory: trueto get the memory in recent geth versions, so this PR does that.I didn't do a comprehensive test of other clients (didn't check besu or erigon), but Ganache (both 6 and 7 at least) have no problem with this option being passed.
Note this still leaves the problem of us not getting storage. I thought the debugger doesn't use that; I forgot that actually it still does in certain cases (namely: when debugging failed contract creations, unless they were performed with
CREATE2). So we'll want to get that too, but I figure that can be left for later; first let's fix the big obvious crash.