Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Allow a few missing values in artifactor/compile-common internals #4126

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

bergarces
Copy link
Contributor

@bergarces bergarces commented Jun 21, 2021

  • @truffle/artifactor: Minor refactor to remove code duplication and show warning if contract_name is missing but contractName is present.
  • @truffle/compile-common: Make properties from ProfilerConfig type optional, as they are currently not being passed in some instances of @truffle/compile-vyper.

None of these are breaking changes.

@bergarces bergarces changed the title Minor refactors with corrections. Minor corrections to compile features for Tezos upgrade Jun 21, 2021
@bergarces bergarces changed the title Minor corrections to compile features for Tezos upgrade Minor corrections for Tezos compiler upgrade Jun 21, 2021
Copy link
Contributor

@haltman-at haltman-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, although I don't entirely understand the "dom" thing.

packages/artifactor/tsconfig.json Outdated Show resolved Hide resolved
@haltman-at
Copy link
Contributor

Great, seems good then!

@bergarces bergarces merged commit a7f0fa7 into develop Jun 25, 2021
@bergarces bergarces deleted the compiler-corrections branch June 25, 2021 12:54
@gnidan gnidan changed the title Minor corrections for Tezos compiler upgrade Allow a few missing values in artifactor/compile-common internals Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants