This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Handle unbox with slashes in branch name Fix/unbox 1676 #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
force-pushed
the
fix/unbox-1676
branch
8 times, most recently
from
61df643
to
823203d
Compare
eggplantzzz
reviewed
Jun 4, 2021
eggplantzzz
reviewed
Jun 4, 2021
eggplantzzz
reviewed
Jun 4, 2021
eggplantzzz
reviewed
Jun 4, 2021
eggplantzzz
reviewed
Jun 4, 2021
eggplantzzz
reviewed
Jun 4, 2021
|
I only found some piddly stuff that doesn't much matter. I didn't nitpick the regexes very much though and kind of relied on the comments. Someone with better regex skills should probably look haha |
eggplantzzz
reviewed
Jun 11, 2021
gnidan
reviewed
Jun 11, 2021
- normalizeSourcePath unit tests for refactor. Starting point for
building enough tests for backward compatibility.
- add test to specify a branch with slashes in name
- set Box and normalizeSourcePath as default and named export
respectively
- implement with regular expressions for more deterministic parsing - handle branches with slashes - try to maintain backward compatibility. More tests may be needed.
This is needed because an integration test, to verify unboxing, uses `Box.sandbox` which references an ora spinner that is somehow undefined. `defaultSubscribers` will likely have to be revisited.
- add test to check GIT@ fails - fix incorrect branch example in test - fix typo in test
- add validation for branch segment - implement logic to validate `git` user
eggplantzzz
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors unbox's normalize function and now handles unbox ing branches with slashes (#1676). Tests have been added to maintain backward compatibility. All current unit and integration tests work, so hopefully...馃
Also added debug output to log input/output state for easier debugging just in case.