This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: Add maxRedirects field to axios requests #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's kind of ugly that we have to do this everywhere. Is there a clean way to refactor this? |
|
In source fetcher we could make that method that accepts the request object take a couple of parameters that get passed in instead? |
|
There is also a |
gnidan
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported here that they were experiencing issues with making http requests while using Truffle from behind a proxy. It seemed reasonable to assume this had something to do with switching axios in for the deprecated request library (see #3997). After a small amount of investigation I discovered that axios has an option for
maxRedirectsthat defaults to 5. In an attempt to fix this http request issue, this PR increasesmaxRedirectsto 50.