This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Clean up develop and console code #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
reviewed
Jun 12, 2019
CruzMolina
reviewed
Jun 24, 2019
packages/truffle-core/lib/console.js
Outdated
| ); | ||
| }) | ||
| fse | ||
| .readFile( |
There was a problem hiding this comment.
can we use fse.readFileSync here?
that way we can keep provision a sync method and remove Promise.all (maybe rename the promises array to jsonBlobs).
There was a problem hiding this comment.
Sure, that would definitely make it a little easier to read! However, I wonder where it is especially useful to use async methods for performance perks...any thoughts @gnidan?
fainashalts
reviewed
Jun 24, 2019
fainashalts
reviewed
Jun 24, 2019
packages/truffle-core/lib/console.js
Outdated
|
|
||
| // If our code includes an await, add special processing to ensure it's evaluated properly. | ||
| if (match) { | ||
| var assign = match[1]; |
There was a problem hiding this comment.
Same question here re: var or let
fainashalts
reviewed
Jun 24, 2019
gnidan
approved these changes
Jun 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to provide better maintainability, this PR seeks to clarify the logic used by the console and develop commands. Callback-style functions are typically converted to Promise-based structures and there are also a handful of syntax updates.