Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Test components #1137

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

jklepatch
Copy link

@honestbonsai
Copy link
Contributor

Thanks! Will get this reviewed.

@@ -0,0 +1,10 @@
const babelOptions = {
presets: ["env", "stage-0", "react"],
plugins: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these for? I ran your tests locally without any plugins and it still worked.

I suggest removing this if they are not needed.

@@ -0,0 +1,10 @@
const babelOptions = {
presets: ["env", "stage-0", "react"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage-0 seems like it's a bit much to me, do you know what JS feature exactly this is adding that the tests need?

I did try running without stage-0 and it didn't work.

@jklepatch
Copy link
Author

jklepatch commented Feb 28, 2019 via email

@honestbonsai
Copy link
Contributor

honestbonsai commented Mar 4, 2019

@jklepatch Yea I see what you mean, .compilerc is using stage-0, so the tests are going to have to use stage-0 as well. I'm ok with keeping it in since it breaks the tests, so something is relying on it.

However, the tests you wrote don't utilize the plugins at all, so I still think it would help to simplify this PR by removing them. In the future, when the tests require the use of one of the plugins we can put it back in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants