Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a glob for include list. #977

Merged
merged 5 commits into from Dec 16, 2022
Merged

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Dec 14, 2022

  • Add include-repos and exclude-repos flag that can be used with the --org flag when scanning Github.
  • Allow for glob input for the exclude/include flags.

Screen Shot 2022-12-14 at 2 28 57 PM

@ahrav ahrav marked this pull request as ready for review December 14, 2022 22:34
@ahrav ahrav requested review from a team as code owners December 14, 2022 22:34
pkg/sources/github/github.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@ahrav ahrav requested review from bill-rich and a team December 15, 2022 20:14
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I didn't see any logic for ExcludeRepos. Is that already being handled somewhere?

@ahrav
Copy link
Collaborator Author

ahrav commented Dec 16, 2022

lgtm, though I didn't see any logic for ExcludeRepos. Is that already being handled somewhere?

Yep we already have the logic within the source itself to exclude repos using the ignoreRepos field.
https://github.com/trufflesecurity/trufflehog/blob/main/pkg/sources/github/github.go#L150

We had implemented that logic for the enterprise version and just needed to add the flag to be used by OSS.

@ahrav ahrav merged commit 936a139 into main Dec 16, 2022
@ahrav ahrav deleted the github-repo-scan-using-glob branch December 16, 2022 21:28
javajawa added a commit to mewbotorg/mewbot that referenced this pull request Dec 26, 2022
Update trufflehog from 3.19.0 to 3.21.0.

- Bump github.com/xanzy/go-gitlab from 0.76.0 to 0.77.0 by @​dependabot in trufflesecurity/trufflehog#981
- Bump golang.org/x/crypto from 0.3.0 to 0.4.0 by @​dependabot in trufflesecurity/trufflehog#982
- Add configuration parsing and custom detectors to engine by @​mcastorina in trufflesecurity/trufflehog#968
- Add custom regex detector docs by @​mcastorina in trufflesecurity/trufflehog#983
- Remove custom log leveler by @​mcastorina in trufflesecurity/trufflehog#985
- Bump github.com/xanzy/go-gitlab from 0.74.0 to 0.76.0 by @​dependabot in trufflesecurity/trufflehog#934
- Bump github.com/bill-rich/disk-buffer-reader from v0.1.6 to v0.1.7 by @​bill-rich in trufflesecurity/trufflehog#970
- Bump go.mongodb.org/mongo-driver from 1.11.0 to 1.11.1 by @​dependabot in trufflesecurity/trufflehog#971
- Bump github.com/getsentry/sentry-go from 0.15.0 to 0.16.0 by @​dependabot in trufflesecurity/trufflehog#973
- [bug] - Handle error when scanning s3 bucket. by @​ahrav in trufflesecurity/trufflehog#969
- Bump github.com/go-git/go-git/v5 from 5.4.2 to 5.5.1 by @​dependabot in trufflesecurity/trufflehog#972
- Bump github.com/envoyproxy/protoc-gen-validate from 0.6.13 to 0.9.1 by @​dependabot in trufflesecurity/trufflehog#963
- Add more logging for git sources by @​mcastorina in trufflesecurity/trufflehog#974
- Add s3 object count to trace logs by @​bill-rich in trufflesecurity/trufflehog#975
- Implement CustomRegex detector by @​mcastorina in trufflesecurity/trufflehog#950
- Use Todoist's REST API v2 by @​goncalossilva in trufflesecurity/trufflehog#978
- Allow using a glob for include list. by @​ahrav in trufflesecurity/trufflehog#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants